Make the repro project work with x86 Windows #99800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly a clone of x64 configuration with these differences: force stdcall calling convention, define HOST_WINDOWS/HOST_X86, skip vxsort library.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
reviewed
Mar 15, 2024
| @@ -1,5 +1,13 @@ | |||
| <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <ItemGroup Label="ProjectConfigurations"> | |||
| <ProjectConfiguration Include="Checked|Win32"> | |||
There was a problem hiding this comment.
Can we call this x86 instead of Win32? (I know that Win32 is the historic default for x86.)
There was a problem hiding this comment.
Will it 100% work if I name it like that? Win32 is what VS offered so I didn't question it. I usually let VS do whatever it wants because it's fewer problems.
There was a problem hiding this comment.
Yeah, you are right. Changing Win32 to x86 in the vcxproj does not work well.
The project files have Win32 in most places, but the VS UI shows x86 in most visible places.
jkotas
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a clone of x64 configuration with these differences: force stdcall calling convention, define HOST_WINDOWS/HOST_X86, skip vxsort library.
Cc @dotnet/ilc-contrib