[release/8.0-staging][mono][interp] Fix inlining of ldarga #97650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inlining a method, all arguments are first copied to new vars. Ldarga is going to be applied on these copies. We were loading the address of the wrong var due to typo.
ghost
assigned 
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsWhen inlining a method, all arguments are first copied to new vars. Ldarga is going to be applied on these copies. We were loading the address of the wrong var due to typo. Backport of #97553 Customer ImpactInlining of methods containing the TestingTested on customer provided sample. RiskVery low. The fix is isolated to the code gen for
|
lewing
approved these changes
Jan 29, 2024
rbhanda
added
Servicing-approved
jeffschwMSFT
merged commit 2767a15
into
dotnet:release/8.0-staging
108 of 111 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inlining a method, all arguments are first copied to new vars. Ldarga is going to be applied on these copies. We were loading the address of the wrong var due to typo.
Backport of #97553
Customer Impact
Inlining of methods containing the
ldargaopcode is broken on mono interpreter. This was reported as a regression from .net 7 (on Blazor WASM project), indirectly caused by an increase of the inline limit for methods.Testing
Tested on customer provided sample.
Risk
Very low. The fix is isolated to the code gen for
ldargaopcode during inlining, which was completely broken before.