-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Bump chrome for testing - linux: 120.0.6099.71, windows: 120.0.6099.71 #95832
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
Cc @thaystg @ilonatommy debugger test failures |
It seems objectId changed format. Now the test is sending {
"functionDeclaration": "function(){const e={__proto__:this.__proto__},t=Object.getOwnPropertyNames(this);for(let r=0;r<t.length;++r){const n=t[r],i=n>>>0;if(String(i>>>0)===n&&i>>>0!=4294967295)continue;const a=Object.getOwnPropertyDescriptor(this,n);a&&Object.defineProperty(e,n,a)}return e}",
"objectId": "7794664587706423672.1.8"
} so edit: they can be negative as well, another example: |
That sounds like some error/failure caused this weird id? |
DebuggerTests.CallFunctionOnTests.CheckVSCodeTestFunction1:
|
It's not an error, the quoted structure comes from
We can fix it and keep fixing it each time the protocol changes on next updates. |
The failure is not due to the objectId though. I was pointing to that as a possible clue. The failure is:
|
Taking a look at the failure. |
Disabling the test, and opened #95950 . |
Failure is a known issue. |
No description provided.