-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Comvariant Failure on s390x #94453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe CI Reported two test failure on S390x
|
/azp run runtime-community |
Commenter does not have sufficient privileges for PR 94453 in repo dotnet/runtime |
huoyaoyuan
reviewed
Nov 7, 2023
...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ComVariant.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 7, 2023
8605e04
to
a7cae16
Compare
a7cae16
to
540b941
Compare
3 tasks
jkotas
reviewed
Nov 8, 2023
...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ComVariant.cs
Show resolved
Hide resolved
jkotas
approved these changes
Nov 8, 2023
Co-authored-by: Jan Kotas <[email protected]>
AaronRobinsonMSFT
approved these changes
Nov 8, 2023
The failures seem to be unrelated. Can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Runtime.InteropServices
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI Reported two test failure on S390x
cc: @uweigand