-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. #93933
Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. #93933
Conversation
…ame conflict resolution.
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsThe PR in #81306 among other things consolidated the property name conflict resolution algorithm to a shared location in Fix #93903.
|
src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Handley <[email protected]>
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6630600960 |
src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small suggestion. LGTM otherwise.
…ame conflict resolution. (dotnet#93933) * Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. * Update src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs Co-authored-by: Jeff Handley <[email protected]> * Address feedback --------- Co-authored-by: Jeff Handley <[email protected]>
The PR in #81306 among other things consolidated the property name conflict resolution algorithm to a shared location in
JsonTypeInfo
, however the shared logic didn't account for theJsonSerializerOptions.PropertyNameCaseInsensitive
setting. This PR rectifies the issue and adds a regression test.Fix #93903.