Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] cleanup for emscripten main in a web worker #92280

Merged
merged 10 commits into from
Sep 22, 2023
Merged

[browser] cleanup for emscripten main in a web worker #92280

merged 10 commits into from
Sep 22, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 19, 2023 •
edited
Loading

  • close the console forwarding socket
  • move virtualWorkingDirectory and applicationArguments to MonoConfig
  • propagate ENVIRONMENT_IS_WORKER which is wrong after starting on web worker
  • fix how ENVIRONMENT_IS_WEB_WORKER and others are detected
  • unified the detection in test-main.js
  • introduce globalThis.dotnetSideCar for such detection
  • eliminate direct window and navigator usage

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Sep 19, 2023
@pavelsavara pavelsavara requested a review from maraf September 19, 2023 14:50
@pavelsavara pavelsavara self-assigned this Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: -

@pavelsavara pavelsavara changed the title [browser] close the console forwarding socket [browser] cleanup for emscripten main in a web worker Sep 19, 2023
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 20, 2023
Closed
Open
Open
@pavelsavara

This comment was marked as outdated.

Sign in to view
@pavelsavara

This comment was marked as outdated.

Sign in to view
This was referenced Sep 21, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Sep 22, 2023
Closed
6 tasks
@pavelsavara pavelsavara marked this pull request as ready for review September 22, 2023 12:41
kg
kg reviewed Sep 22, 2023
View reviewed changes
kg
kg approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'm not an expert on some pieces of it

@pavelsavara pavelsavara merged commit 8bcd03c into dotnet:main Sep 22, 2023
@pavelsavara pavelsavara deleted the browser_close_console_socket branch September 22, 2023 20:39
@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @kg