-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix impNonConstFallback #91345
Fix impNonConstFallback #91345
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes #91335 I don't think it needs to be ported to 8.0 because non-constant values for imm-like arguments are not a production scenario (and is expected to cause compiler warrnings).
|
These can happen frequently for cases like the evaluating things in the debugger. I think more notably there won't be any problems here because the underlying instruction expects 16-byte alignment and that's what the constant will be (and more concretely, the instructions support any alignment technically). The assert is only because it's expecting homogenous arguments and so checking for 32-byte alignment since we're expecting all constants are properly aligned (because that's good for perf). Since there's no functional correctness (nor even a bad CQ) issue here, there's no need to backport as it will never surface to the end user. |
Fixes #91335
I don't think it needs to be ported to 8.0 because non-constant values for imm-like arguments are not a production scenario (and is expected to cause compiler warrnings).