Fix warnings found with CA1861 Avoid constant arrays as arguments

[buyaa-n]

Enable new analyzer CA1861: Avoid constant arrays as arguments. And fix warnings found in runtime.

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Enable new analyzer CA1861: Avoid constant arrays as arguments. And fix warnings found in runtime.

Author:	buyaa-n
Assignees:	buyaa-n
Labels:	area-Meta
Milestone:	-

[danmoseley]

This is a potential deoptimization if the call is rarely made, right?

[kg]

Mono parts look fine

[jkotas]

I see that the analyzer has auto-fixer. Is the auto-fixer smart enough to skip cases where the array is mutated later? I am just wondering about potential correctness problems introduced by the auto-fixer.

[buyaa-n]

I see that the analyzer has auto-fixer. Is the auto-fixer smart enough to skip cases where the array is mutated later?

It only flag literal arrays and suggest a fixer

[radical]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stephentoub]

I see that the analyzer has auto-fixer. Is the auto-fixer smart enough to skip cases where the array is mutated later?

It only flag literal arrays and suggest a fixer

I believe Jan is expressing concern about a case like this:

char[] array = new char[] { 'a', 'b', 'c' };
array[0] = Read();
Use(array);

Will the analyzer flag that and auto-fix it to:

private static readonly char[] s_cached = new char[] { 'a', 'b', 'c' };
...
char[] array = s_cached;
array[0] = Read();
Use(array);

? If it would, that's obviously not safe.

[buyaa-n]

I believe now there is no any blocker or open question/comment for this PR, please finish the review @danmoseley @jkotas @kg @stephentoub, thank you!

[buyaa-n]

Failures unrelated and looks all known including #86919