Implement Micrososoft.Bcl.Cryptography without System.Security.Cryptography.Algorithms #85683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our use of
IncrementalHash
inMicrosoft.Bcl.Cryptography
so that we can remove the dependency onSystem.Security.Cryptography.Algorithms
.Instead, use the in-box HMAC and hashing capabilities.
We could keep using
IncrementalHash
for thenetstandard2.0
builds, but it would only give a small improvement for performance. Since this is a compatibility package, I'm not terribly worried about it. The in-box SP800108 will use the best-available APIs. I'd rather avoid yet-another pivot for target framework for this project.Contributes to #85641
/cc @ViktorHofer