Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Micrososoft.Bcl.Cryptography without System.Security.Cryptography.Algorithms #85683

Merged
merged 3 commits into from
May 3, 2023

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented May 2, 2023

This removes our use of IncrementalHash in Microsoft.Bcl.Cryptography so that we can remove the dependency on System.Security.Cryptography.Algorithms.

Instead, use the in-box HMAC and hashing capabilities.

We could keep using IncrementalHash for the netstandard2.0 builds, but it would only give a small improvement for performance. Since this is a compatibility package, I'm not terribly worried about it. The in-box SP800108 will use the best-available APIs. I'd rather avoid yet-another pivot for target framework for this project.

Contributes to #85641

/cc @ViktorHofer

@ghost
Copy link

ghost commented May 2, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This removes our use of IncrementalHash in Microsoft.Bcl.Cryptography so that we can remove the dependency on System.Security.Cryptography.Algorithms.

Instead, use the in-box HMAC and hashing capabilities.

We could keep using IncrementalHash for the netstandard2.0 builds, but it would only give a small improvement for performance. Since this is a compatibility package, I'm not terribly worried about it. The in-box SP800108 will use the best-available APIs. I'd rather avoid yet-another pivot for target framework for this project.

Contributes to #85641

/cc @ViktorHofer

Author: vcsjones
Assignees: vcsjones
Labels:

area-System.Security

Milestone: -

@vcsjones vcsjones requested a review from ViktorHofer May 2, 2023 21:42
@ViktorHofer ViktorHofer merged commit 0b04dfd into dotnet:main May 3, 2023
@vcsjones vcsjones deleted the bcl-hmac branch May 3, 2023 12:29
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants