Avoid S.R.I.RuntimeInformation package dependency #85642
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
ViktorHofer
force-pushed
the
AvoidRuntimeInformationPkgDependency
branch
from
3a524df to
4238e86
Compare
ViktorHofer
added
area-Infrastructure-libraries
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsContributes to #85641 System.Runtime.InteropServices.RuntimeInformation/4.3.0 is being referenced in a few .NET Framework builds. The reference to that package is undesirable as it brings in the entire netstandard1.x dependency graph. Instead, use System.Environment.OSVersion which returns "Microsoft cc @dotnet/area-dependencymodel @dotnet/area-extensions-hosting @dotnet/area-extensions-logging
|
ViktorHofer
force-pushed
the
AvoidRuntimeInformationPkgDependency
branch
3 times, most recently
from
a313a67 to
747bd18
Compare
Contributes to dotnet#85641 System.Runtime.InteropServices.RuntimeInformation/4.3.0 is being referenced in a few .NET Framework builds. The reference to that package is undesirable as it brings in the entire netstandard1.x dependency graph. Instead, use System.Environment.OSVersion which returns "Microsoft Windows NT" on .NET Framework, Mono and .NETCoreApp runtimes.
ViktorHofer
force-pushed
the
AvoidRuntimeInformationPkgDependency
branch
from
747bd18 to
1754a36
Compare
| @@ -106,11 +106,15 @@ public static IServiceCollection AddWindowsService(this IServiceCollection servi | |||
|
|
|||
| private static void AddWindowsServiceLifetime(IServiceCollection services, Action<WindowsServiceLifetimeOptions> configure) | |||
| { | |||
| #if !NETFRAMEWORK | |||
| Debug.Assert(RuntimeInformation.IsOSPlatform(OSPlatform.Windows)); | |||
There was a problem hiding this comment.
These don't seem all that valuable. According to 04442bf#r759693314 it's to workaround an issue in the analyzer. I wonder if that issue still exists?
There was a problem hiding this comment.
I wonder if that issue still exists?
Probably would still warn as I don't see any annotation or guard. Isn't it windows only? Then we might want to add [SupportedOSPlatformGuard("windows")] attribute to this type to suppress the warnings here and propagate the warning to the callers
| #if !NETFRAMEWORK | ||
| RuntimeInformation.IsOSPlatform(OSPlatform.Windows); | ||
| #else | ||
| Environment.OSVersion.StartsWith("Microsoft Windows NT"); |
There was a problem hiding this comment.
This should always return true anyway when running with NETFX. why we bother getting the OS version anyway?
src/libraries/Microsoft.Extensions.DependencyModel/src/EnvironmentWrapper.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Contributes to #85641
System.Runtime.InteropServices.RuntimeInformation/4.3.0 is being referenced in a few .NET Framework builds. The reference to that package is undesirable as it brings in the entire netstandard1.x dependency graph.
Instead, use System.Environment.OSVersion which returns "Microsoft
Windows NT" on .NET Framework, Mono and .NETCoreApp runtimes.
cc @dotnet/area-dependencymodel @dotnet/area-extensions-hosting @dotnet/area-extensions-logging