Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] es6 test main #85542

Merged
merged 2 commits into from
May 3, 2023
Merged

[browser] es6 test main #85542

merged 2 commits into from
May 3, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 28, 2023 •
edited
Loading

@pavelsavara pavelsavara added this to the 8.0.0 milestone Apr 28, 2023
@pavelsavara pavelsavara requested a review from maraf April 28, 2023 22:05
@pavelsavara pavelsavara self-assigned this Apr 28, 2023
@ghost
Copy link

ghost commented Apr 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 29, 2023
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 29, 2023
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2023
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara mentioned this pull request May 2, 2023
Merged
@pavelsavara pavelsavara force-pushed the browser_es6_test_main branch from be1ba0c to 4ba5015 Compare May 3, 2023 10:46
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review May 3, 2023 10:48
@pavelsavara pavelsavara requested review from lewing and radical as code owners May 3, 2023 10:48
@pavelsavara pavelsavara requested a review from kg as a code owner May 3, 2023 10:48
kg
kg approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can verify that BDN still works after these changes (I think they use test-main, so it should keep working?) everything else looks fine

This was referenced May 3, 2023
Closed
Closed
@pavelsavara
feedback
64bc328 
add nodeJS explicit exit
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

maraf
maraf approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara pavelsavara merged commit bda61b9 into dotnet:main May 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
@pavelsavara pavelsavara deleted the browser_es6_test_main branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@radical radical Awaiting requested review from radical

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @kg @maraf