Avoid producing Requires* warnings when accessing constant fields

[vitek-karas]

Fields can only be annotated with Requires* attributes through their type (so RUC on type and so on). But that annotation is actually not guarding access to the field itself, but it's actually guarding access to static members, including static constructor.

Constant fields don't trigger static constructor. In fact at runtime constant fields are never accessed by code. The compiler is required to inline their values instead.

So IL based scanners will never produce the above warning, only analyzer would.

This change modifies the analyzer to stop producing warings for accessing constant fields.

Fixes #84433

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fields can only be annotated with Requires* attributes through their type (so RUC on type and so on). But that annotation is actually not guarding access to the field itself, but it's actually guarding access to static members, including static constructor.

Constant fields don't trigger static constructor. In fact at runtime constant fields are never accessed by code. The compiler is required to inline their values instead.

So IL based scanners will never produce the above warning, only analyzer would.

This change modifies the analyzer to stop producing warings for accessing constant fields.

Fixes #84433

Author:	vitek-karas
Assignees:	vitek-karas
Labels:	area-Tools-ILLink
Milestone:	8.0.0

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fields can only be annotated with Requires* attributes through their type (so RUC on type and so on). But that annotation is actually not guarding access to the field itself, but it's actually guarding access to static members, including static constructor.

Constant fields don't trigger static constructor. In fact at runtime constant fields are never accessed by code. The compiler is required to inline their values instead.

So IL based scanners will never produce the above warning, only analyzer would.

This change modifies the analyzer to stop producing warings for accessing constant fields.

Fixes #84433

Author:	vitek-karas
Assignees:	vitek-karas
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	8.0.0

[lewing]

@thaystg

C:\helix\work\workitem\e>set DEBUGGER_TEST_PATH=C:\helix\work\workitem\e/debugger-test 

C:\helix\work\workitem\e>set BROWSER_PATH_FOR_TESTS=C:\helix\work\correlation\chrome-win\chrome.exe 

C:\helix\work\workitem\e>set SKIP_LOG_TO_CONSOLE=1 

C:\helix\work\workitem\e>if /I [WasmDebuggerTests] == [WasmTestOnNodeJS] (call npm ci  ) 

C:\helix\work\workitem\e>dotnet.exe test DebuggerTestSuite/DebuggerTestSuite.dll "-l:trx;LogFileName=testResults.trx" "-l:console;Verbosity=normal" --results-directory "C:\helix\work\workitem\uploads\xharness-output\logs" --filter FullyQualifiedName~DebuggerTests.EvaluateOnCallFrameTests -v diag  

Welcome to .NET 8.0!
---------------------
SDK Version: 8.0.100-preview.1.23115.2

----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
Microsoft (R) Test Execution Command Line Tool Version 17.6.0-preview-20230126-02 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 3000 seconds and was killed

['chrome-DebuggerTests.EvaluateOnCallFrameTests' END OF WORK ITEM LOG: Command timed out, and was killed]

[lewing]

@pavelsavara

[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer
[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer
[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer
[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer
[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer
[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer
[13:06:54] info: Unable to evaluate script: disconnected: unable to send message to renderer

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 1800 seconds and was killed

['WasmTestOnBrowser-System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

[lewing]

@vitek-karas the wasm failures are unrelated

[sbomer]

LGTM, thanks!

[eerhardt]

Thanks, @vitek-karas!