Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a regression test out of CI #80399

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Conversation

cshung
Copy link
Member

@cshung cshung commented Jan 9, 2023

This change should move the test out of CI.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@BruceForstall
Copy link
Member

Related: #78899

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add this test to src\tests\issues.targets which will completely disable the test (for all the appropriate targets/platforms).

fyi, general guidance: https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/disabling-tests.md

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 11, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 11, 2023
Co-authored-by: Bruce Forstall <[email protected]>
@cshung cshung merged commit eb4d230 into dotnet:main Jan 12, 2023
@cshung cshung deleted the public/disable-for-78899 branch January 12, 2023 23:14
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants