-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism for runtime to query host for information #78798
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Detailsnull
|
1e0983a
to
4e6645c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this 😄
Just the minor comment about priority of the properties, otherwise looks great.
src/installer/tests/Assets/TestProjects/HostApiInvokerApp/HostRuntimeContract.cs
Show resolved
Hide resolved
Would be good to add a short description of this into the docs in the repo - along with "why are we doing this" and "how we see it being used in the future"... and finally "this is the future way of passing more properties to the runtime". Basically document the decisions and design - doesn't have to be long, it's pretty simple at the end. |
Pass a struct from the host to the runtime as a new property
HOST_RUNTIME_CONTRACT
. The runtime can use this to query for information from the host.get_runtime_property
: get the value of a property from the host. The host's current implementation just handles the same properties given to the runtime on initialization. It can be updated to handle/compute additional information on-demand as the need arises.bundle_probe
: existing function used for single-filepinvoke_override
: existing function used for single-fileThe struct can be extended in the future to handle more specific/structured information in a nicer way than property strings (for example separate function to get or enumerate the TPA / probing paths).
Resolves #77458