Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Pass resource items for VS generated authoring #75454

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Sep 12, 2022

Description

A non-existing property instead of an item is being passed to the workload generation task. It won't cause build breaks because the task has fallback logic that will extract information from the workload manifest when it generates the SWIX authoring for VS.

It is ignoring all the specific resource values and versions we're providing for workloads. The version numbers are the more critical concern for the component and component group authoring as it will require manually updating authoring in VS when we insert.

Testing

Manually verify the intermediate JSON manifests generated for Visual Studio using an official build. Otherwise, wait for a staging build to verify the files being pushed to VSDROP for an insertion (likely too late to take corrective actions)

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned joeloff Sep 12, 2022
@lewing
Copy link
Member

lewing commented Sep 12, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3038953590

@lewing
Copy link
Member

lewing commented Sep 12, 2022

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/3038955202

@lewing lewing changed the title Pass resource items for VS generated authoring [release/6.0] Pass resource items for VS generated authoring Sep 12, 2022
@carlossanlop
Copy link
Member

@lewing @joeloff how confident are that this won't cause a build break like it did in the release/7.0?

@joeloff
Copy link
Member Author

joeloff commented Sep 13, 2022

@lewing @joeloff how confident are that this won't cause a build break like it did in the release/7.0?

I'd be very surprised if it did. We already took the Arcade 6.0 update in a previous PR for both runtime and EMSDK- this just fixes a set of values that was incorrectly passed to the build task so it was generating bad descriptions for the items we insert to VS

@carlossanlop
Copy link
Member

Apparently the Mono minijit Pri0 Runtime Tests Run Linux arm64 release leg is stuck due to some infra problem:

##[error]We stopped hearing from agent NetCore-Svc-Public 94. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

Talked to @joeloff and we can merge with the rest of the legs in green.

@carlossanlop carlossanlop merged commit 2789259 into dotnet:release/6.0 Sep 13, 2022
vseanreesermsft pushed a commit to vseanreesermsft/runtime that referenced this pull request Oct 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants