-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Pass resource items for VS generated authoring #75454
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3038953590 |
/backport to main |
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/3038955202 |
I'd be very surprised if it did. We already took the Arcade 6.0 update in a previous PR for both runtime and EMSDK- this just fixes a set of values that was incorrectly passed to the build task so it was generating bad descriptions for the items we insert to VS |
Apparently the
Talked to @joeloff and we can merge with the rest of the legs in green. |
Description
A non-existing property instead of an item is being passed to the workload generation task. It won't cause build breaks because the task has fallback logic that will extract information from the workload manifest when it generates the SWIX authoring for VS.
It is ignoring all the specific resource values and versions we're providing for workloads. The version numbers are the more critical concern for the component and component group authoring as it will require manually updating authoring in VS when we insert.
Testing
Manually verify the intermediate JSON manifests generated for Visual Studio using an official build. Otherwise, wait for a staging build to verify the files being pushed to VSDROP for an insertion (likely too late to take corrective actions)