Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Make System.Transactions.Local trimmable #75004

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 2, 2022

Backport of #74828 to release/7.0

/cc @lewing @radekdoulik

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

On other target platforms than windows.

This fixes #74506

The reason to make it non-trimmable is that it uses COM interop
on windows. So we can make it trimmable again on other target platforms.
#74506 (comment)
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allows unusable assembly to be trimmed out

@lewing lewing added this to the 7.0.0 milestone Sep 2, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. once we have a green ci we can merge

@carlossanlop
Copy link
Member

I logged issues for the two CI failures. They seem unrelated to this change.
Approved and signed off.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit d2e3961 into release/7.0 Sep 2, 2022
@carlossanlop carlossanlop deleted the backport/pr-74828-to-release/7.0 branch September 2, 2022 23:56
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants