Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not R2R NativeAOT compiler on ARM64 machines #74856

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

@a74nh
Copy link
Contributor

a74nh commented Aug 31, 2022

This fixes my build issues. Thanks for raising this.

Am I right in thinking eventually this will be reverted once nuget gets updated?

@MichalStrehovsky
Copy link
Member Author

Am I right in thinking eventually this will be reverted once nuget gets updated?

Yep.

@MichalStrehovsky MichalStrehovsky merged commit 68d55a6 into dotnet:main Aug 31, 2022
@MichalStrehovsky MichalStrehovsky deleted the arm64wrk branch August 31, 2022 08:28
@AndyAyersMS
Copy link
Member

Is it possible this changed behavior of crossgen2? We are seeing some hard to explain regressions:

dotnet/perf-autofiling-issues#8205
dotnet/perf-autofiling-issues#8204

@MichalStrehovsky
Copy link
Member Author

Is it possible this changed behavior of crossgen2

This doesn't affect the way crossgen2 builds. This is not even using a crossgen2 from this repo, but a crossgen2 that comes from the SDK.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants