Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add signing infrastructure for diagnostic binaries #74330

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Aug 22, 2022

Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.

@ghost ghost assigned hoyosjs Aug 22, 2022
@hoyosjs hoyosjs added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed area-Diagnostics-coreclr labels Aug 22, 2022
@ghost
Copy link

ghost commented Aug 22, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.

Author: hoyosjs
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@hoyosjs hoyosjs marked this pull request as draft August 22, 2022 07:37
@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 22, 2022

@ghost
Copy link

ghost commented Aug 25, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.

Author: hoyosjs
Assignees: hoyosjs
Labels:

NO-MERGE, area-Infrastructure

Milestone: -

@hoyosjs hoyosjs requested review from mmitche, jeffschwMSFT and a team September 14, 2022 23:02
@hoyosjs hoyosjs added Servicing-consider Issue for next servicing release review and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Sep 14, 2022
@hoyosjs hoyosjs marked this pull request as ready for review September 14, 2022 23:02
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. as this is an infrastructure only change, this is tell mode.

cc @carlossanlop to let us know when it is safe to merge

@hoyosjs hoyosjs added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 14, 2022
@hoyosjs hoyosjs merged commit e02e231 into dotnet:release/6.0 Sep 15, 2022
@hoyosjs hoyosjs deleted the juhoyosa/dac-sign-6.0 branch September 15, 2022 16:11
vseanreesermsft pushed a commit to vseanreesermsft/runtime that referenced this pull request Oct 11, 2022
…net#74330)

* Add DAC signature infrastructure
* Add signature verification
@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants