Provide upgrade response details #71757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #25918 Providing web socket upgrade response status code and headers.
|
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
stephentoub
reviewed
Jul 7, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Browser.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 7, 2022
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 7, 2022
src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 11, 2022
src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 11, 2022
src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 11, 2022
src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Natalia Kondratyeva <[email protected]>
This reverts commit 0713bd8.
CarnaViire
reviewed
Jul 11, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocket.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 11, 2022
…ockets/ClientWebSocket.cs Co-authored-by: Natalia Kondratyeva <[email protected]>
CarnaViire
reviewed
Jul 11, 2022
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
MihaZupan
reviewed
Jul 12, 2022
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 12, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Managed.cs
Outdated
Show resolved
Hide resolved
…ockets/WebSocketHandle.Managed.cs Co-authored-by: Stephen Toub <[email protected]>
stephentoub
approved these changes
Jul 12, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Browser.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/WebSocketHandle.Managed.cs
Outdated
Show resolved
Hide resolved
MihaZupan
reviewed
Jul 12, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocketOptions.cs
Outdated
Show resolved
Hide resolved
...tem.Net.WebSockets.Client/src/System/Net/WebSockets/HttpResponseHeadersReadOnlyCollection.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <[email protected]> Co-authored-by: Stephen Toub <[email protected]>
MihaZupan
approved these changes
Jul 12, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25918
Providing web socket upgrade response status code and headers.