Update apphost error dialog text to put question last #71165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsWe had the question/call to action followed by the doc link and then the yes/no buttons corresponding to the question. As @RussKie pointed out, that placement was not helpful. cc @richlander Reordered to:
|
vitek-karas
approved these changes
Jun 22, 2022
richlander
approved these changes
Jun 22, 2022
|
Very great. Thanks for the contribution. I don't know how realistic this is (due to backwards compatibility), but in the long run it would be imo better to use a newer dialogue instead of the standard Win32 dialogue? I think the Windows 10 API offers something like that. Edit: Its a WinRT API |
deeprobin
approved these changes
Jun 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the question/call to action followed by the doc link and then the yes/no buttons corresponding to the question. As @RussKie pointed out, that placement was not helpful.
cc @richlander
Reordered to:
