Sort ConstrainedDirectCall cells #71121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a generic dictionary has multiple constrained calls, we would crash the compiler. I hit this in tests for dotnet#67745 but I want to separate this from the fix because that one is going to be quite a bit of code.
ghost
assigned 
vitek-karas
approved these changes
Jun 22, 2022
|
@jkotas could you have a look as well? I would ideally like to get this in before the preview 6 cutoff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a generic dictionary has multiple constrained calls, we would crash the compiler.
I hit this in tests for #67745 but I want to separate this from the fix because that one is going to be quite a bit of code.