Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][aot] Enabled System.Globalization.Extensions.Tests #71077

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[wasm][aot] Enabled System.Globalization.Extensions.Tests #71077

merged 1 commit into from
Jun 21, 2022

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jun 21, 2022 •
edited
Loading

Fixes #58708.

Tested with:
dotnet build /t:Test src/libraries/System.Globalization.Extensions/tests /p:TargetOS=Browser /p:Configuration=Release /p:RunAOTCompilation=true /p:BrowserHost=Windows

result:

  info: === TEST EXECUTION SUMMARY ===
  info: Total: 290, Errors: 0, Failed: 0, Skipped: 0, Time: 25.209501s

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization wasm-aot-test WebAssembly AOT Test labels Jun 21, 2022
@ilonatommy ilonatommy added this to the 7.0.0 milestone Jun 21, 2022
@ilonatommy ilonatommy requested a review from radical June 21, 2022 18:41
@ghost ghost assigned ilonatommy Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58708.

Tested with:
dotnet build -bl /t:Test src/libraries/System.Globalization.Extensions/tests /p:TargetOS=Browser /p:Configuration=Release /p:RunAOTCompilation=true /p:BrowserHost=Windows

result:

  info: === TEST EXECUTION SUMMARY ===
  info: Total: 290, Errors: 0, Failed: 0, Skipped: 0, Time: 25.209501s
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-System.Globalization, wasm-aot-test
Milestone: 7.0.0

@radical
Copy link
Member

radical commented Jun 21, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

radical
radical approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests pass.

@radical
Copy link
Member

radical commented Jun 21, 2022

The NativeAOT failure is #70010 and unrelated to this PR.

@radical radical merged commit ff4ae18 into dotnet:main Jun 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[wasm][aot] Windows: Test failures for System.Globalization.Extensions.Tests
2 participants
@ilonatommy @radical