Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Wasm] Add missing libicudata.a for native layout #70682

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: [Wasm] Add missing libicudata.a for native layout #70682

merged 1 commit into from
Jun 21, 2022

Conversation

jeromelaban
Copy link
Contributor

This PR adds libicudata.a to the native layout, following the recent updates in libicu transport packages.

@jeromelaban jeromelaban requested a review from marek-safar as a code owner June 13, 2022 17:47
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 13, 2022
@lewing lewing requested review from kg and radical June 13, 2022 23:34
@lewing lewing added the arch-wasm WebAssembly architecture label Jun 13, 2022
@ghost
Copy link

ghost commented Jun 13, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR adds libicudata.a to the native layout, following the recent updates in libicu transport packages.

Author: jeromelaban
Assignees: -
Labels:

arch-wasm, area-Build-mono, community-contribution
Milestone: -

@radical
Copy link
Member

radical commented Jun 16, 2022

@jeromelaban What kinda problem do you see with the file missing?

@jeromelaban
Copy link
Contributor Author

There's a symbol in libicuuc.a referencing libicudata.a, causing emcc to fail with a missing symbol:

wasm-ld: error: /tmp/dotnet-runtime-wasm-linux-49cc2e9-e96642078cf-2393138755-Release/runtimes/browser-wasm/native/libicuuc.a(udata.ao): undefined symbol: icudt68_dat

This either means that the default runtime build does not use this specific symbol, or it's somehow linked out by the default runtime configuration.

@radical
Copy link
Member

radical commented Jun 17, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit ad8b979 into dotnet:main Jun 21, 2022
@radical
Copy link
Member

radical commented Jun 21, 2022

@jeromelaban Thank you for the contribution 👍

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@kg kg kg approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromelaban @radical @kg @marek-safar @lewing