Consolidate morphing of local nodes #69819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a new entrypoint for morphing of all local nodes -
fgMorphLocal
, and utilizes it to remove the restriction on morphing of "x86 stack args under varargs" inLocalAddressVisitor
, in preparation of doing the same with implicit byrefs.Diffs: we have some TP regressions; I have traced them down to MSVC not inlining things, e. g. if I put
FORCEINLINE
onfgMorphLeaf
, I get a negative PIN diff overall. I hope our PGO builds will make up for this. Additionally, the upcoming implicit byref change has some very nice TP wins attached to it.We also have (expected) GC info diffs:
The reason is that we now transform the address of the varargs cookie itself to
LCL_VAR_ADDR
:And so the rationalizer doesn't retype it back to
TYP_BYREF
: