Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Bump emscripten to 3.1.7 #67006

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

radekdoulik
Copy link
Member

No description provided.

@radical
Copy link
Member

radical commented Mar 23, 2022

To keep the PR progressing, I updated the exported functions list to _malloc,_memalign,_memset,_htons,_ntohs.

@radical
Copy link
Member

radical commented Mar 24, 2022

The Wasm.Build.Tests failures are because the emscripten packages are still on 3.1.1 .
ref: Radek's PR for emsdk bump - dotnet/emsdk#124

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Mar 28, 2022

the debugger test failure should be unrelated. It's racy, and I'll open a PR with a fix.

@lewing
Copy link
Member

lewing commented Mar 28, 2022

mono osx and linux failures appear to be #60962

@lewing lewing marked this pull request as ready for review March 28, 2022 22:15
@lewing lewing requested a review from marek-safar as a code owner March 28, 2022 22:15
@lewing
Copy link
Member

lewing commented Mar 28, 2022

Failures are logged and unrelated.

@lewing lewing merged commit 34fdf89 into dotnet:main Mar 28, 2022
radekdoulik added a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
* Bump emscripten to 3.1.7

* Use new docker images with emscripten 3.1.7

* Update exported functions list for 3.1.7:

* Use 3.1.7 emsdk and icu packages

Co-authored-by: Ankit Jain <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants