Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revocation processing on expired chains. #66968

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

bartonjs
Copy link
Member

When adding tracing to the Linux X509Chain build, the "when do we process revocation" check got cleaned up to avoid doing wasteful work. But it got cleaned a bit too aggressively.

With this change, fully-valid and valid-except-for-validity chains will both move into active revocation checks.

Fixes #66803

@ghost
Copy link

ghost commented Mar 22, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

When adding tracing to the Linux X509Chain build, the "when do we process revocation" check got cleaned up to avoid doing wasteful work. But it got cleaned a bit too aggressively.

With this change, fully-valid and valid-except-for-validity chains will both move into active revocation checks.

Fixes #66803

Author: bartonjs
Assignees: -
Labels:

area-System.Security

Milestone: -

@bartonjs
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Member

vcsjones commented Mar 22, 2022

Looks like the test passed in outerloop and other failures appear unrelated.

@bartonjs bartonjs merged commit 8b42dff into dotnet:main Mar 22, 2022
@bartonjs bartonjs deleted the linux_x509chain_expired_revoked branch March 22, 2022 22:30
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants