Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verification of open delegates #65425

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Fix verification of open delegates #65425

merged 2 commits into from
Feb 17, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Feb 16, 2022

Fixes #65010

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILVerification Issues related to ilverify tool and IL verification in general label Feb 16, 2022
@ghost ghost assigned jkotas Feb 16, 2022
@ghost
Copy link

ghost commented Feb 16, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65010

Author: jkotas
Assignees: -
Labels:

area-ILVerification

Milestone: -

return false;

int totalTargetArgs = targetSignature.Length + (targetSignature.IsStatic ? 0 : 1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy of the CoreCLR VM logic for delegate verification.

@jkotas jkotas merged commit 385fc88 into dotnet:main Feb 17, 2022
@jkotas jkotas deleted the delegates branch February 17, 2022 08:08
@jcouv
Copy link
Member

jcouv commented Feb 17, 2022

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILVerification Issues related to ilverify tool and IL verification in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILVerification fails unexpectedly on delegate construction
4 participants