-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand System.Runtime.InteropServices.NFloat to support the APIs required by Xamarin #64234
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like two operators are reversed?
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
6414489
to
4b38c4e
Compare
[NonVersionable] | ||
public static bool operator !=(NFloat left, NFloat right) => left._value != right._value; | ||
|
||
/// <summary>Compares two values to determine which is less.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This description seems a bit misleading, as it tells you whether left is less than right but not whether right is strictly less then left.
Consider adopting the existing doc terminology that float/double use, e.g. "Returns a value that indicates whether a specified Double value is less than or equal to another specified Double value."
That goes for all these doc comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adopting the existing doc terminology
I always forget that we have APIs exposed here that are functionally unavailable and will never be called 👍
I'll update this in a follow up PR as I need to also update IComparisonOperators
and a few other places accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a quick skim and generally LGTM.
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1774427144 |
This resolves #63801.
Tests still need to be added.