Console.Unix: fix OpenStandardInput Stream sometimes throwing for Reads. #62153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connected to a terminal reads happen line-by-line. StdInReader caches the line in a StringBuilder. Instead of returning when the destination buffer is full, an attempt was made to decode the next chunk from the StringBuilder (if there is one). This causes the encoder to throw for encoding into an empty buffer.
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
area-System.Console
and removed
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsWhen connected to a terminal reads happen line-by-line. StdInReader caches the line in a StringBuilder. Instead of returning when the destination buffer is full, an attempt Fixes #61865. @dotnet/area-system-console ptal. cc @dmbarbour
|
adamsitnik
reviewed
Nov 30, 2021
There was a problem hiding this comment.
@tmds thank you for your contribution! I've left some comments, PTAL
|
Adam, thank you for reviewing! I've addressed your feedback. |
adamsitnik
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connected to a terminal reads happen line-by-line.
This was added in .NET 5 by #39192.
StdInReader caches the line in a StringBuilder.
Instead of returning when the destination buffer is full, an attempt
was made to decode the next chunk from the StringBuilder (if there is
one). This causes the encoder to throw for encoding into an empty buffer.
Fixes #61865.
@dotnet/area-system-console ptal.
cc @dmbarbour