Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Update dependencies from dotnet/arcade #61422

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 10, 2021

Fixes #61216

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 36974d0f-1ebe-4d41-3a49-08d961c5a689
  • Build: 20211110.2
  • Date Produced: November 10, 2021 5:15:38 PM UTC
  • Commit: ee9b7f19853685805c612103282c8d9486c7db86
  • Branch: refs/heads/release/6.0
  • Updates to .NET SDKs:
    • Updates sdk.version to 6.0.100
    • Updates tools.dotnet to 6.0.100

…108.5

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21558.5
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Nov 10, 2021
@Anipik
Copy link
Contributor

Anipik commented Nov 10, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…110.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21560.2
@mmitche
Copy link
Member

mmitche commented Nov 11, 2021

@Anipik I think this is required, correct?

@Anipik
Copy link
Contributor

Anipik commented Nov 11, 2021

yes thats correct

@mmitche
Copy link
Member

mmitche commented Nov 11, 2021

/cc @safern

@Anipik
Copy link
Contributor

Anipik commented Nov 11, 2021

pushed #61260 into this branch to save us time.

@Anipik
Copy link
Contributor

Anipik commented Nov 11, 2021

cc @safern can you take a look at the failures here ? seems to be cause by the arcade update.

Co-authored-by: Santiago Fernandez Madero <[email protected]>
@Anipik
Copy link
Contributor

Anipik commented Nov 12, 2021

@maryamariyan can you take a look at the extensions failures ? arcade update is breaking this one.

@safern
Copy link
Member

safern commented Nov 12, 2021

I'm taking a look as well. I'm trying to repro locally.

@Anipik
Copy link
Contributor

Anipik commented Nov 12, 2021

Thanks :)

@safern
Copy link
Member

safern commented Nov 13, 2021

I found the culprit. What's causing this issue is the SDK update to 6.0.100. If I revert back to the 6.0Basically what is happening is that when building test projects the PlatformManifest under the targeting pack that we produce under artifacts\bin\microsoft.netcore.app.ref\data\PlatformManifest.txt is not being found/returned by the ResolveTargetingPackAssets Task. What caused this is: dotnet/sdk@70f204b.

You can see that we also hit this when upgrading the main branch to RC2: #60256 (comment)

We are hitting this because of how we build runtime and how we generate the PlatformManifest after building some projects and hence the ref pack is cached and we don't get the PlatformManifest because the cached instance didn't have any PlatformManifest.txt.

We usually don't bump the SDK outside of infra rollouts, however since the branch is closed I think is fine and then whenever we send out the email to let people know about the 6.0.100 SDK update in main, we can mention it happened on 6.0 as well.

I'll push the workaround shortly.

FYI: @jkoritzinsky as you are driving the main SDK update.

@Anipik
Copy link
Contributor

Anipik commented Nov 15, 2021

@safern any update on tihs one ?

@safern
Copy link
Member

safern commented Nov 15, 2021

@Anipik this is ready to be merged. The failure is unrelated.

@Anipik Anipik merged commit 0c78d80 into release/6.0 Nov 15, 2021
@safern safern deleted the darc-release/6.0-85428b80-1da0-43e1-8ffe-bdff57d0949b branch November 15, 2021 18:16
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants