-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify runtime test projects #60724
Simplify runtime test projects #60724
Conversation
/azp run runtime-coreclr outerloop |
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @hoyosjs Issue DetailsDon't specify defaults in the test project files, to simplify them:
|
The only test failure is #60152; others are infra failures. The total number of outerloop tests remained the same (465,858). |
@dotnet/runtime-infrastructure PTAL. Comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the simplification!
Nice! I assume we could simplify them even further by moving OutputType and AllowUnsafeBlocks to a common Directory.Build.props too? |
Yeah, maybe it would make sense to make OutputType Exe the default and set that in src\tests\Directory.Build.targets along with the CLRTestKind/CLRTestPriority defaults. AllowUnsafeBlocks is only set when needed, so I don't think that needs any cleanup. |
Don't specify defaults in the test project files, to simplify them:
CLRTestPriority
of zero is the default, so don't specify that: commit 3d37868CLRTestKind
ofBuildAndRun
is the default, so don't specify that: commit 799129b