-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Win11 RIDs #58588
Add Win11 RIDs #58588
Conversation
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsIn reaction to #58125
|
/cc @agocke We will probably want to backport this to 6 I assume? (I'm looking for Win11 VM to test this on) |
Yup, we'll want to backport |
Windows 11 reported its OS version as 10 when I checked last time. Is it still the case or does it report 11 now? |
I think it is better to think about this as core OS version (kernel version in Linux world) vs. OS distro name and version. Windows 11 in the dialog you have shared is like a distro name and version. If Windows Server 2022 had this dialog, I think it would present itself as |
This may have also interplay with |
I tried on a much later Win11 build than @wfurt (thanks for looking into it) and it's still the same: 10.0.22488. Which means that the code we have to detect current RID would still pick win10. Actually I tested it with the updated RID graph and it does still say win10 everywhere. I assume this means we don't want to introduce the win11 RIDs. Might cause slight confusion for users, but I agree that the impact to SDK and such is probably not worth it (especially since the OS also treats itself as win10 in other areas as well). |
In reaction to #58125