Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Win11 RIDs #58588

Closed
wants to merge 1 commit into from
Closed

Add Win11 RIDs #58588

wants to merge 1 commit into from

Conversation

vitek-karas
Copy link
Member

In reaction to #58125

@ghost
Copy link

ghost commented Sep 2, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

In reaction to #58125

Author: vitek-karas
Assignees: vitek-karas
Labels:

area-Infrastructure-libraries

Milestone: -

@vitek-karas
Copy link
Member Author

/cc @agocke

We will probably want to backport this to 6 I assume?

(I'm looking for Win11 VM to test this on)

@agocke
Copy link
Member

agocke commented Sep 2, 2021

Yup, we'll want to backport

@jkotas
Copy link
Member

jkotas commented Sep 2, 2021

Windows 11 reported its OS version as 10 when I checked last time. Is it still the case or does it report 11 now?

@wfurt
Copy link
Member

wfurt commented Sep 2, 2021

Environment.OSVersion reports Microsoft Windows NT 10.0.22000.0.
While this may be technically right OS presents itself to user as
image

I'm wondering if OS plays some mapping trick like Apple did for macOS 11.

@jkotas
Copy link
Member

jkotas commented Sep 2, 2021

I think it is better to think about this as core OS version (kernel version in Linux world) vs. OS distro name and version.

Windows 11 in the dialog you have shared is like a distro name and version. If Windows Server 2022 had this dialog, I think it would present itself as Windows Server 2022 (no mention of either 10 or 11). Both Windows 11 and Windows Server 2022 distros still use Windows 10.X core OS. I agree that it is very confusing.

@jkotas
Copy link
Member

jkotas commented Sep 2, 2021

This may have also interplay with TargetFramework and TargetPlatformMinVersion https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/desktop-to-uwp-enhance#supporting-multiple-windows-os-versions . If we introduce win11 RID even though everything else considers it to be Windows 10 core OS, we may need mapping in between the two in the SDK in some places.

@vitek-karas
Copy link
Member Author

I tried on a much later Win11 build than @wfurt (thanks for looking into it) and it's still the same: 10.0.22488. Which means that the code we have to detect current RID would still pick win10. Actually I tested it with the updated RID graph and it does still say win10 everywhere.

I assume this means we don't want to introduce the win11 RIDs. Might cause slight confusion for users, but I agree that the impact to SDK and such is probably not worth it (especially since the OS also treats itself as win10 in other areas as well).

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@vitek-karas vitek-karas deleted the AddWin11RID branch January 14, 2022 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants