[release/6.0-rc1][wasm] Require workloads if using @(NativeFileReference)
#58148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIf a project is using Fixes #56678 .
|
radical
force-pushed
the
workload-native-ref
branch
from
7879452 to
4f692c7
Compare
radical
requested review from
eiriktsarpalis,
imhameed,
lambdageek,
layomia,
SamMonoRT,
steveharter,
thaystg and
vargaz
as code owners
radical
changed the title
@(NativeFileReference)@(NativeFileReference)
radical
removed request for
vargaz,
lambdageek,
eiriktsarpalis,
thaystg,
steveharter,
layomia,
SamMonoRT and
imhameed
|
I have opened this against |
radical
force-pushed
the
workload-native-ref
branch
from
4f692c7 to
6b97708
Compare
radical
changed the title
@(NativeFileReference)@(NativeFileReference)
radical
force-pushed
the
workload-native-ref
branch
from
68b0b53 to
127d48f
Compare
radical
added
the
NO-MERGE
Currently, if the `wasm-tools` workload is not installed, and a project uses AOT, then the build fails with an error saying that the workload is needed. But if the project is using native references, but not AOT, then the build does not fail. Instead, the `@(NativeFileReference)` just gets ignored. Even though the wasm workload is needed to relink dotnet.wasm with the native libraries. Implementation: - `$(RunAOTCompilation)` is a property, so it can be checked, and wasm workload imports can be enabled. - But `@(NativeFileReference)` is an item, and that gets evaluated in the second phase, so we can't use that to affect the imports. Instead, a custom target is used.
radical
force-pushed
the
workload-native-ref
branch
from
127d48f to
cdeff4d
Compare
radical
removed
the
NO-MERGE
|
closing this while we discuss an alternative approach. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a blazorwasm project has
$(RunAOTCompilation)=true, then thewasm-toolsworkload is marked as required. But this is not done if the project wants to use native libraries, without AOT.This PR makes the workload a requirement when such native libraries are being used (
@(NativeFileReference)). This will cause the build to fail if the workload is not installed.Fixes #56678 .
Customer Impact
Instead of the native library, silently, not getting linked, and failing at runtime, this fails the build.
Testing
CI. New tests added.
Risk