Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-rc1] Add event to RuntimeEventSource for AppContext switches #57847

Merged
merged 21 commits into from
Aug 25, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 20, 2021

Backport of #57303 to release/6.0-rc1

/cc @agocke

Customer Impact

Adds event gathering for AppContext switches, helpful for diagnosing issues related to feature flags, or other runtime configurations.

Testing

Unit tests, manual verification.

Risk

Low

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing
Copy link
Member

lewing commented Aug 22, 2021

This needs #57890 before it should go in.

* Skip RuntimeEventSource tests on wasm and android

* Skip tests without using issues.targets

* Disable test for mono

(cherry picked from commit 454ac57)
@SteveMCarroll SteveMCarroll added the Servicing-approved Approved for servicing release label Aug 24, 2021
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a code review and we can merge.

@agocke agocke requested a review from josalem August 24, 2021 17:48
Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this has the test exclusion from #57890 this should be good to go :)

@jeffschwMSFT
Copy link
Member

@Anipik we are good to merge. Is now a good time?

@mmitche mmitche merged commit 75e6a7f into release/6.0-rc1 Aug 25, 2021
@akoeplinger akoeplinger deleted the backport/pr-57303-to-release/6.0-rc1 branch August 28, 2021 22:04
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tracing-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants