-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align DCJS with 4.8 implementation. #57533
Merged
StephenMolloy
merged 4 commits into
dotnet:main
from
StephenMolloy:55270-DataContractJsonSerializer-Mishandles-ExtensionData
Aug 21, 2021
Merged
Align DCJS with 4.8 implementation. #57533
StephenMolloy
merged 4 commits into
dotnet:main
from
StephenMolloy:55270-DataContractJsonSerializer-Mishandles-ExtensionData
Aug 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
approved these changes
Aug 18, 2021
mconnew
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/backport to release/6.0-rc1 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1154087468 |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1154088599 |
This was referenced Aug 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align DCJS with 4.8 implementation.
DCJS in .Net Core (and previously, going back to the days of
Silverlight) has been a wild evolution of features being cut
and added back and morphed as the features and concepts
of the associated runtimes have changed. This PR should
finally bring DCJS back inline with the current .Net 4.8
implementation.
In the process of doing so, this PR also corrects a couple of
places where DCJS was mis-stepping to cause the bug described
in #55270, which is a regression from NetFx.
Fixes #55270