Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align DCJS with 4.8 implementation. #57533

Conversation

StephenMolloy
Copy link
Member

Align DCJS with 4.8 implementation.

DCJS in .Net Core (and previously, going back to the days of
Silverlight) has been a wild evolution of features being cut
and added back and morphed as the features and concepts
of the associated runtimes have changed. This PR should
finally bring DCJS back inline with the current .Net 4.8
implementation.

In the process of doing so, this PR also corrects a couple of
places where DCJS was mis-stepping to cause the bug described
in #55270, which is a regression from NetFx.

Fixes #55270

Copy link
Member

@mconnew mconnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenMolloy StephenMolloy changed the base branch from main to release/6.0-rc1 August 20, 2021 21:56
@StephenMolloy StephenMolloy changed the base branch from release/6.0-rc1 to main August 21, 2021 05:04
@StephenMolloy StephenMolloy merged commit 36697a5 into dotnet:main Aug 21, 2021
@StephenMolloy
Copy link
Member Author

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1154087468

@StephenMolloy
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1154088599

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataContractJsonSerializer can't serialize contract with ExtensionDataObject
3 participants