-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Capture.ValueSpan #57357
Add Capture.ValueSpan #57357
Conversation
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue DetailsBased on offline discussion with area owners and API review.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the tests as well!
Nit: The test .csproj file somehow got a UTF-8 BOM appended. Consider re-saving this file as "UTF-8 without BOM".
Edit: I think I looked at the diff backward and that your PR actually removes the BOM. Hooray! 🎉
@stephentoub Thanks for starting this! |
Yes |
Based on offline discussion with area owners and API review.
Contributes to #23602