Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Capture.ValueSpan #57357

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Add Capture.ValueSpan #57357

merged 1 commit into from
Aug 13, 2021

Conversation

stephentoub
Copy link
Member

Based on offline discussion with area owners and API review.
Contributes to #23602

@ghost
Copy link

ghost commented Aug 13, 2021

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on offline discussion with area owners and API review.
Contributes to #23602

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions

Milestone: 6.0.0

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the tests as well!

Nit: The test .csproj file somehow got a UTF-8 BOM appended. Consider re-saving this file as "UTF-8 without BOM".

Edit: I think I looked at the diff backward and that your PR actually removes the BOM. Hooray! 🎉

@electricessence
Copy link

electricessence commented Aug 13, 2021

@stephentoub Thanks for starting this!
I'm guessing this isn't gonna be public for a while?
.NET 6?

@stephentoub stephentoub merged commit 7898f9b into dotnet:main Aug 13, 2021
@stephentoub stephentoub deleted the capturevaluespan branch August 13, 2021 22:58
@stephentoub
Copy link
Member Author

.NET 6?

Yes

@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants