Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the (Get|Set)CompressedStack obsoletions to use SYSLIB0003 #56874

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Update the (Get|Set)CompressedStack obsoletions to use SYSLIB0003 #56874

merged 2 commits into from
Aug 5, 2021

Conversation

jeffhandley
Copy link
Member

Per feedback in #56690 (comment), we should use SYSLIB0003 on this existing obsoletion as it's more accurate than the previous message--it's even more obsolete now than it used to me.

This is an exceptionally minor breaking change (which I'll log a breaking change documentation issue for). If someone was previously suppressing CS0618, this change will introduce a new warning for them under the diagnostic ID of SYSLIB0003.

@dotnet-issue-labeler

This comment has been minimized.

Sign in to view
@ghost
Copy link

ghost commented Aug 4, 2021

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Per feedback in #56690 (comment), we should use SYSLIB0003 on this existing obsoletion as it's more accurate than the previous message--it's even more obsolete now than it used to me.

This is an exceptionally minor breaking change (which I'll log a breaking change documentation issue for). If someone was previously suppressing CS0618, this change will introduce a new warning for them under the diagnostic ID of SYSLIB0003.

Author: jeffhandley
Assignees: -
Labels:

area-System.Threading, new-api-needs-documentation
Milestone: -

@jeffhandley jeffhandley added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed new-api-needs-documentation labels Aug 4, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 4, 2021
@ghost
Copy link

ghost commented Aug 4, 2021

Tagging @dotnet/compat for awareness of the breaking change.

@jeffhandley jeffhandley self-assigned this Aug 4, 2021
@jeffhandley jeffhandley added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Aug 4, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 4, 2021
@ghost
Copy link

ghost commented Aug 4, 2021 •
edited by jeffhandley
Loading

Note regarding the needs-breaking-change-doc-created label:

This serves as a reminder that when a pull request is labeled as a breaking-change, that a corresponding breaking change document issue needs to be created. Once the breaking change document issue is created and linked to this pull request, the needs-breaking-change-doc-created label can be removed. Breaking changes must also be announced through the .NET Breaking Change Notification DL.

  1. Create a new .NET breaking change documentation issue. The issue template uses form fields to guide you through the process.
  2. Ensure there is a link between the PR and the docs issue
  3. Remove the needs-breaking-change-doc-created label from this PR
  4. Announce the breaking change to the .NET Breaking Change Notification DL

Tagging @dotnet/compat for awareness of the breaking change.

@jeffhandley jeffhandley mentioned this pull request Aug 4, 2021
Closed
2 tasks
@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 4, 2021
@MihaZupan MihaZupan mentioned this pull request Aug 5, 2021
Closed
@jeffhandley
Copy link
Member Author

Test failures are #56925 and #56269

@jeffhandley jeffhandley merged commit df05666 into dotnet:main Aug 5, 2021
@jeffhandley jeffhandley deleted the jeffhandley/obsoletion-compressedstack branch August 5, 2021 19:10
@karelz karelz mentioned this pull request Aug 10, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@jeffhandley jeffhandley

Labels
area-System.Threading breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffhandley @stephentoub