Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test SendMoreThanStreamLimitRequests_Succeeds for all QUIC #56566

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Disable test SendMoreThanStreamLimitRequests_Succeeds for all QUIC #56566

merged 1 commit into from
Jul 30, 2021

Conversation

karelz
Copy link
Member

@karelz karelz commented Jul 29, 2021

Disable the test also for MsQuic, not just Mock.

Test types:

  • System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic
  • System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_Mock

Disabled test tracked by #55957

@karelz
Disable test SendMoreThanStreamLimitRequests_Succeeds for all QUIC
6341390 
Disable the test also for MsQuic, not just Mock.

Test types:
- System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic
- System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_Mock

Disabled test tracked by #55957
@karelz karelz added this to the 6.0.0 milestone Jul 29, 2021
@karelz karelz requested a review from wfurt July 29, 2021 17:51
@ghost
Copy link

ghost commented Jul 29, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable the test also for MsQuic, not just Mock.

Test types:

  • System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic
  • System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_Mock

Disabled test tracked by #55957

Author: karelz
Assignees: -
Labels:

area-System.Net.Quic
Milestone: 6.0.0

wfurt
wfurt approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I have occasional local repro so we should be able to investigate.

@karelz
Copy link
Member Author

karelz commented Jul 30, 2021

Test failures unrelated:

System.NullReferenceException : Object reference not set to an instance of an object
Stack Trace:
    /_/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs(987,0): at Microsoft.Extensions.Configuration.Test.ConfigurationTests.BindingDoesNotThrowIfReloadedDuringBinding()
    /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(370,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@karelz karelz merged commit fae1412 into main Jul 30, 2021
This was referenced Jul 30, 2021
Closed
Closed
@akoeplinger akoeplinger deleted the karelz-patch-2 branch August 2, 2021 10:00
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@karelz @wfurt