Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start codesign from executable on apphost creation #56010

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

mateoatr
Copy link
Contributor

UseShellExecute should be false whenever we are redirecting to standard error (as we are doing when firing codesign when creating an apphost).

Fixes #55992.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-HostModel Microsoft.NET.HostModel issues label Jul 20, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

UseShellExecute should be false whenever we are redirecting to standard error (as we are doing when firing codesign when creating an apphost).

Fixes #55992.

Author: mateoatr
Assignees: -
Labels:

area-HostModel

Milestone: -

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateoatr mateoatr merged commit b1af9bf into dotnet:main Jul 20, 2021
@mrward
Copy link

mrward commented Jul 22, 2021

@mateoatr Can this be backported to the release/6.0-preview7 branch?

@mateoatr
Copy link
Contributor Author

/backport to release/6.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1056552619

@agocke
Copy link
Member

agocke commented Jul 22, 2021

Unfortunately this is too late for P7 -- I would recommend setting <UseAppHost>false</> for now

@agocke
Copy link
Member

agocke commented Jul 22, 2021

(Or running the SDK on the CLR, using the CLI)

@mrward
Copy link

mrward commented Jul 22, 2021

Workaround above ^ /cc @jmatthiesen @sevoku

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HostWriter.CodeSign fails when building .NET 6 preview 7 Angular projects with Visual Studio for Mac.
5 participants