-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start codesign from executable on apphost creation #56010
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke Issue Details
Fixes #55992.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mateoatr Can this be backported to the release/6.0-preview7 branch? |
/backport to release/6.0-preview7 |
Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1056552619 |
Unfortunately this is too late for P7 -- I would recommend setting |
(Or running the SDK on the CLR, using the CLI) |
Workaround above ^ /cc @jmatthiesen @sevoku |
UseShellExecute
should be false whenever we are redirecting to standard error (as we are doing when firingcodesign
when creating an apphost).Fixes #55992.