[mono] Allow overriding CustomAttributeData accessors #55728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Constructor, ConstructorArguments, and NamedArguments in internal routines to allow them being overridden (like with CoreCLR).
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
approved these changes
Jul 15, 2021
marek-safar
reviewed
Jul 16, 2021
Comment on lines
153
to
156
| public virtual Type AttributeType | ||
| { | ||
| get { return ctorInfo.DeclaringType!; } | ||
| get { return Constructor.DeclaringType!; } | ||
| } |
There was a problem hiding this comment.
Please move the code to the shared location once it exists
marek-safar
reviewed
Jul 16, 2021
| @@ -152,30 +152,28 @@ public static IList<CustomAttributeData> GetCustomAttributes(ParameterInfo targe | |||
|
|
|||
| public virtual Type AttributeType | |||
| { | |||
| get { return ctorInfo.DeclaringType!; } | |||
| get { return Constructor.DeclaringType!; } | |||
| } | |||
|
|
|||
| public override string ToString() | |||
There was a problem hiding this comment.
Please move the code to the shared location once it exists
|
Closing in favour of #55726 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routines to allow them being overridden (like with CoreCLR).
Even after #55726,
System.Text.Json.SourceGeneration.Testsare still failing when using a Mono-based dotnet runtime. This new problem is triggered because the source-generation logic provides a classCustomAttributeDataWrapperderived fromCustomAttributeData, which overrides the latter class' accessor routinesConstructor,ConstructorArguments, andNamedArguments.This works with CoreCLR. However, with the current Mono implementation, other routines in
CustomAttributeDatanow crash when called on an instance of the derived class, because they now access internal data members that have never been initialized. Fix this by instead calling the accessor routines like in CoreCLR.