-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUIC logging update #55500
QUIC logging update #55500
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTogether with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one, e.g.:
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTogether with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one, e.g.:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Did you get the trace sample on Windows?
Seems like different casing on pointers. I'm wondering if this is something intentional or something that can be fixed @nibanks. |
We use CLOG to convert the LTTng traces on Linux and generally netsh to convert the ETW traces on Windows. Right now, there's no guarantee that casing will be the same across everything. |
Improvement for CLOG? While you can use case insensitive text search it would be nice if this is as simple as possible. |
Yes; on Windows it's uppercase 🙁
|
Together with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one, e.g.: