Root built-in converters in JsonSerializerOptions.GetConverter(Type) #51897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsThe JSON source generator does not generate calls to this method, so we don't need to make a breaking change. In this PR, we restore backwards-compat by rooting built-in converters. We can provide a new size-friendly API if the scenario comes up.
|
This was referenced Apr 26, 2021
steveharter
reviewed
Apr 27, 2021
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Apr 27, 2021
...s/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSourceGeneratorTests.cs
Show resolved
Hide resolved
layomia
force-pushed
the
GetConverter
branch
2 times, most recently
from
a059c30 to
fa79d9f
Compare
steveharter
approved these changes
Apr 28, 2021
|
Hello @layomia! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@eerhardt, @steveharter, @eiriktsarpalis - PTAL commit 8afd77e which marks |
eerhardt
reviewed
Apr 29, 2021
...ries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON source generator does not generate calls to this method, so we don't need to make a breaking change. In this PR, we restore backwards-compat by rooting built-in converters. We can provide a new size-friendly API if the scenario comes up.