Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Merge Start into Listener constructor #51512

Merged
merged 5 commits into from
Apr 21, 2021

Conversation

CarnaViire
Copy link
Member

Fixes #2262

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #2262

Author: CarnaViire
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@ManickaP
Copy link
Member

Could we talk about this change first? I'm still not convinced that coupling Start with ctor is a way to go. For example, TcpListener has Start, LocalEndpoint keeps port 0 until you start it. I don't see anything particularly wrong with keeping the behavior same here.

@CarnaViire CarnaViire merged commit d08f7f2 into dotnet:main Apr 21, 2021
@CarnaViire CarnaViire deleted the merge-start branch April 21, 2021 16:49
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUIC] QuicListener.ListenEndPoint returns a port of 0 if Start() hasn't been called
4 participants