Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an internal zlib on wasm to avoid emscripten downloading one. #48881

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Use an internal zlib on wasm to avoid emscripten downloading one. #48881

merged 1 commit into from
Mar 2, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Feb 28, 2021

No description provided.

@vargaz vargaz requested a review from akoeplinger February 28, 2021 07:14
@CoffeeFlux
Copy link
Contributor

This still leaves multiple identical copies of zlib in the build tree - would be nice to clean that up.

Base automatically changed from master to main March 1, 2021 09:08
@vargaz vargaz merged commit fbf3d5e into dotnet:main Mar 2, 2021
@vargaz vargaz deleted the wasm-zlib branch March 2, 2021 04:58
@CoffeeFlux CoffeeFlux mentioned this pull request Mar 5, 2021
Closed
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@CoffeeFlux CoffeeFlux Awaiting requested review from CoffeeFlux

@marek-safar marek-safar Awaiting requested review from marek-safar

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-Build-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vargaz @CoffeeFlux @lambdageek @karelz