Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reflection] Remove sre-save and DISABLE_REFLECTION_EMIT_SAVE #47915

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

lambdageek
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Contributor

@CoffeeFlux CoffeeFlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lambdageek
Copy link
Member Author

Updated not to conflict with #47925
It' does leave ves_icall_ModuleBuilder_WriteToFile and ves_icall_ModuleBuilder_build_metadata uncompilable (but they're not built on netcore) until that PR removes them.

So this should go second.

@CoffeeFlux CoffeeFlux merged commit 306f9e2 into dotnet:master Feb 6, 2021
@lambdageek lambdageek deleted the mono-rm-sre-save branch February 9, 2021 19:28
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants