Add AOT support for the EntryPoint property for UnmanagedCallersOnly. #44809
Conversation
…returns the beginning of the metadata string so its length can be computed.
vargaz
requested review from
CoffeeFlux,
lambdageek,
SamMonoRT and
thaystg
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vargaz
force-pushed
the
aot-entrypoint
branch
from
a4b33ed to
c0f837a
Compare
| export_name [slen] = 0; | ||
| } | ||
| } | ||
| g_free (named_args); |
There was a problem hiding this comment.
| g_free (named_args); | |
| g_assert (!typed_args); | |
| g_free (named_args); |
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
| MonoMethod *wrapper; | ||
|
|
||
| if (!(method->flags & METHOD_ATTRIBUTE_STATIC)) { | ||
| g_warning ("AOT restriction: Method '%s' must be static since it is decorated with [UnmanagedCallers].", |
There was a problem hiding this comment.
Is this permanent limitation?
There was a problem hiding this comment.
It's part of the spec of UnmanagedCallersOnlyAttribute
It is an error to apply the attribute to anything other than an ordinary static method or ordinary static local function. The C# compiler will mark any non-static or static non-ordinary methods imported from metadata with this attribute as unsupported by the language.
There was a problem hiding this comment.
Why do we check only for this restriction then and shouldn't this be TLE or something like that?
There was a problem hiding this comment.
Its just a copy paste from the MonoPInvokeCallback case.
ghost
locked as resolved and limited conversation to collaborators
Fixes #44803.