-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced GetDirectoryNameOfFileAbove with GetPathOfFileAbove #43462
Conversation
@marek-safar can you help please, any idea why the build is failing |
You can ignore the failure, it's infrastructure issue |
This is for #30468 Hi @TaurahSP , thanks for the contribution, but there are a few issues here
I am going to close this PR and feel free to create a new one if you want to give another shot. Or, you could choose to pick a different issue as you prefer. |
https://docs.microsoft.com/en-us/visualstudio/msbuild/property-functions?view=vs-2019 describes what each does |
Replaced "$([MSBuild]::GetDirectoryNameOfFileAbove(" with "$([MSBuild……]::GetPathOfFileAbove(" to improve readability