Stop using transport packages for CoreCLR assets #40002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashook
approved these changes
Jul 28, 2020
|
Known issue #40034 with blank patch |
|
@hoyosjs are any of these transport packages legacy and should be removed? |
|
@ViktorHofer ILasm, ILDasm, and SDK.IL are all public facing, the test host is used, ilverify and the global tool for it are new as of preview 7. This remove all the transport packages, but the runtime components are necessary. |
agocke
pushed a commit
that referenced
this pull request
Jul 30, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the uses of transport packages are fulfilled in some other way now: flow to upstream repositories is either done with other packages or gone with the runtime merge, and all symbols are indexed with symbol packages.
Fixes #38924