add SupportsTls11 and SupportsTls12 to PlatformDetection avoid OS versions in tests #39482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
area-System.Net.Security
test-enhancement
|
Tagging subscribers to this area: @dotnet/ncl |
|
This will have to be ported to Preview8 branch as well since there are failures there too. |
|
@dotnet/ncl this is hitting a few jobs, could someone please review, and we can fix preview 8 also? reopening PR to pick up fixes to WASM tests.. |
danmoseley
added
the
blocking-clean-ci
ManickaP
reviewed
Jul 18, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/ServerAsyncAuthenticateTest.cs
Outdated
Show resolved
Hide resolved
ManickaP
reviewed
Jul 19, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/ServerAsyncAuthenticateTest.cs
Outdated
Show resolved
Hide resolved
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…sions in tests (dotnet#39482) * add SupportsTls11 and SupportsTls12 to avoid OS versions in tests * feedback from review * fix condition
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like Debian10 does not want to do TLS1.1 by default. We may see more of the in the future.
fixes #39445