Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit liveness fix. #38591

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Jit liveness fix. #38591

merged 1 commit into from
Jul 1, 2020

Conversation

erozenfeld
Copy link
Member

fgComputeLifeUntrackedLocal can be called multiple times for the same
lclVarNode since fgLocalVarLiveness may call
fgInterBlockLocalVarLiveness multiple times. Therefore,
m_promotedStructDeathVars may be updated more than once for the same
node.

Fixes #38496.

`fgComputeLifeUntrackedLocal` can be called multiple times for the same
`lclVarNode` since `fgLocalVarLiveness` may call
`fgInterBlockLocalVarLiveness` multiple times. Therefore,
`m_promotedStructDeathVars` may be updated more than once for the same
node.

Fixes dotnet#38496.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 30, 2020
@erozenfeld erozenfeld requested a review from CarolEidt June 30, 2020 00:26
@erozenfeld
Copy link
Member Author

@CarolEidt @dotnet/jit-contrib PTAL

Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erozenfeld
Copy link
Member Author

@DrewScoggins Looks like Performance Linux x64 release mono JIT net5.0 completed successfully but is reporting failure?
https://helix.dot.net/api/2019-06-17/jobs/b7970103-a08b-4a51-a338-fd068db4b3e0/workitems/release.Partition5/files/console.7884fbae.log

@erozenfeld erozenfeld merged commit a2ef44f into dotnet:master Jul 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: JIT\\SIMD\\MinMax_ro\\MinMax_ro.cmd
3 participants